The GitHub Actions job "Tests" on airflow.git has succeeded.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
1b788420589de4aea7eb8b93053b8af2580c5119 / Ash Berlin-Taylor <[email protected]>
Tidy up dagrun tests by removing many uses of `ti.run()` (#46021)

While this wasn't a problem before, having `ti.run` in the dagrun tests makes
porting code to the TaskSDK much more complicated. It also arguably makes them
more of integration tests than unit tests, which is no bad thing in and of
itself, but `ti.run()` can't work on SerializedDAG, so it means that the tests
are not quite representative of what the Scheduler will actually be doing.

Most of this change is to swap from calling run to setting the state (and
sometimes adding a TaskMap row) and then checking the scheduling decisions
result.

I have added the need_serialized_dag marker to the tests I touched. In the
next PR I create (that I extracted this out of) I apply this marker to all the
entire file, but that also needs porting manny of the dynamic task mapping
tests, and since I will be moving those soon I didn't touch them here too.

The test_prev_dagrun_dep file has been removed as it was only used in two
specific tests in this file, so it's better to inline it directly there.

How is this change deleting so many files? By removing duplicated or
almost-duplicated tests, namely these pairs. There were too many tests that
had almost identical bodies.

For example, testing that reducing a map length to zero isn't noticably
different to testing that a map length reduces by 2.

Report URL: https://github.com/apache/airflow/actions/runs/12956277425

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to