The GitHub Actions job "Tests" on airflow.git has failed. Run started by GitHub user ashb (triggered by ashb).
Head commit for run: 76b9e8a05ad101510de72b8168210b165bf257bf / Ash Berlin-Taylor <[email protected]> Render structured logs in the new UI rather than showing raw JSON There are multiple parts to this PR; First off: the log reader interface was _a mess_ There was some odd+old code do deal with reading from multiple hosts that made the message confusing. This was added for smart sensors (which went away in v2.4 or v2.5) but this mess remained, and reading from multiple hosts is handled differently now. This PR keeps the current "parse+interleave" behaviour (though it's debatable if the interleave feature is needed specifically, or if we could get away with a simpler concat instead. Future work there if anyone wants to think about and tackle this.) but changes the JSON resposne type from a single string (the value of which was previoulsy a mess of double encoded JSON and repr of a python tuple making it impossible to do anything but display at) to a list of either strings (when it can't be parsed) or a list of dicts/StructuredLogMessage. I have also done some cursory rendering/displaying of these structured log messages in the UI, but they could be greatly improved by adding colors to various components of the log. The current rendered HTML looks like this: ```html <p><span class="event">::group::Log message source details</span> <span class="log-key sources">sources=["/root/airflow/logs/dag_id=trigger_test/run_id=manual__2025-02-16T12:23:29.118614+00:00_gOTl0Qub/task_id=waiter/attempt=1.log","/root/airflow/logs/dag_id=trigger_test/run_id=manual__2025-02-16T12:23:29.118614+00:00_gOTl0Qub/task_id=waiter/attempt=1.log.trigger.14.log"]</span></p> <p><span class="event">::endgroup::</span></p> <p>[<time datetime="2025-02-16T12:23:30.033308">2025-02-16T12:23:30.033308</time>] <span class="log-level debug">DEBUG</span> - <span class="event">Hook impls: []</span> <span class="log-key logger">logger="airflow.listeners.listener"</span></p> ``` Although not used by the UI, the non-application/json content type is now updated to a) include the continuation token as a header, and to set the content type as application/x-ndjson Report URL: https://github.com/apache/airflow/actions/runs/13372866702 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
