The GitHub Actions job "Tests" on airflow.git has succeeded.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
c341726abbb91cc95cdb02cbe6ea90630d8fca7f / Jarek Potiuk <[email protected]>
Fix overriding of package suffix by skipped packages (#46960)

The version-suffix-for-local change (#43769) had a seemingly innocent
change:

https://github.com/apache/airflow/pull/43769/files#diff-54ea68b5e1e61ac0437df0ab7d99dc508595323b11847a957931e0d9007962d7L942

but this change caused that when package was skipped, it reset the
suffix that was set with --version-suffix-for-pypi and
--version-suffix-for-local - for ALL subsequent packages.

This was because it was not obvious that the version suffix is reset
with every loop, and it was not obvious that when package was
considered to be skipped, it also reset the returned version
suffix to an empty string.

Combination of the two caused the problem:

This change fixes it by:

* returning original suffix even if package is skipped
* extracting building packages to separate method where the package
  version is a local variable and even if overwritten it would cause
  no harm

Report URL: https://github.com/apache/airflow/actions/runs/13457875970

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to