The GitHub Actions job "Tests" on airflow.git/fix-error-dr-prev has succeeded.
Run started by GitHub user kaxil (triggered by kaxil).

Head commit for run:
b009f16704c3a98e487cadfec1ecf99567aa7536 / Kaxil Naik <[email protected]>
Fix bug in `previous-successful-dagrun` Execution API endpoint

The bug was as mentioned in https://github.com/apache/airflow/issues/48503 
where the `logical_date` of the currrent TI was None.

We should return an empty `PrevSuccessfulDagRunResponse()` but because we 
weren't checking for it, the API server failed with:

```
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py:1160:
 in test_ti_with_none_as_logical_date
    response = 
client.get(f"/execution/task-instances/{ti.id}/previous-successful-dagrun")
/usr/local/lib/python3.10/site-packages/starlette/testclient.py:465: in get
    return super().get(
...
...
/usr/local/lib/python3.10/site-packages/cadwyn/schema_generation.py:504: in 
__call__
    return self._original_callable(*args, **kwargs)
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:555:
 in get_previous_successful_dagrun
    DR.logical_date < task_instance.logical_date,
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/operators.py:368: in 
__lt__
    return self.operate(lt, other)
/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/attributes.py:322: in 
operate
    return op(self.comparator, *other, **kwargs)
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/operators.py:368: in 
__lt__
    return self.operate(lt, other)
/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/properties.py:426: in 
operate
    return op(self.__clause_element__(), *other, **kwargs)
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/operators.py:368: in 
__lt__
    return self.operate(lt, other)
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/elements.py:873: in 
operate
    return op(self.comparator, *other, **kwargs)
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/operators.py:368: in 
__lt__
    return self.operate(lt, other)
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/type_api.py:1379: in 
operate
    return super(TypeDecorator.Comparator, self).operate(
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/type_api.py:77: in 
operate
    return o[0](self.expr, op, *(other + o[1:]), **kwargs)
/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/default_comparator.py:95:
 in _boolean_compare
    raise exc.ArgumentError(
E   sqlalchemy.exc.ArgumentError: Only '=', '!=', 'is_()', 'is_not()', 
'is_distinct_from()', 'is_not_distinct_from()' operators can be used with 
None/True/False
```

Report URL: https://github.com/apache/airflow/actions/runs/14145571037

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to