The GitHub Actions job "Tests AMD" on airflow.git/ipv6-dual-stack-logs-fix has succeeded. Run started by GitHub user ashb (triggered by ashb).
Head commit for run: 643b3433692b9fd98b82063bbd8a7f3a48e1c120 / Ash Berlin-Taylor <[email protected]> Simplify serve_logs IPv4/v6 binding We were trying to be "smart" about what interface we listened on, but that isn't really needed, and passing an empty host achieves the same effect: ``` $ netstat -antlp | grep 8793 tcp 0 0 0.0.0.0:8793 0.0.0.0:* LISTEN 85699/airflow serve tcp6 0 0 :::8793 :::* LISTEN 85699/airflow serve ``` The existing approach was working fine for most people (including myself) it was working fine and listening on ipv6 and v4 wildcard interfaces as expected, but some Docker/container set ups this was not the case, and despite Dualstack saying True, listening on `::` ended up _only_ listening on IPv6, but the entry in `/etc/hosts` in the container only had an entry for the IPv4 address of the pod, which we weren't listening on, so log requests would fail. Which is all a round about way of saying "doing less works better" 😀 (We also don't need the getattr+lambda anymore, as that was to support Python <= 3.7!) Fixes #55470 Report URL: https://github.com/apache/airflow/actions/runs/17763857754 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
