The GitHub Actions job "Tests AMD" on airflow.git/issue-46616 has failed. Run started by GitHub user NilsJPWerner (triggered by pierrejeambrun).
Head commit for run: dbefee1865592d31fc64bac78fb9ac40ae01f7ee / Nils Werner <[email protected]> Fix custom timetable generate_run_id not called for manual triggers In Airflow 3.x, commit 035060d7f3 (PR #46616) changed the trigger_dag module to use DagRun.generate_run_id() instead of dag.timetable.generate_run_id() for manual DAG runs. This bypassed custom timetable logic, causing a regression from Airflow 2.x behavior. This commit restores the use of dag.timetable.generate_run_id() for manual triggers, allowing custom timetables to control run_id generation for both scheduled and manually triggered runs. Changes: - airflow/api/common/trigger_dag.py: Changed to call dag.timetable.generate_run_id() with run_after and data_interval parameters instead of DagRun.generate_run_id() - tests/api_fastapi/core_api/routes/public/test_dag_run.py: Added test to verify custom timetable generate_run_id is called for manual triggers with both logical_date provided and null This pattern matches how manual triggers are handled in other parts of the codebase (e.g., assets.py, scheduler_job_runner.py). Fixes: #55908 Report URL: https://github.com/apache/airflow/actions/runs/18230800130 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
