The GitHub Actions job "Tests AMD" on airflow.git/bugfix/grid-view-task-ordering has succeeded. Run started by GitHub user dheerajturaga (triggered by dheerajturaga).
Head commit for run: a99c496acd7a2e1956ad25f891a6071c7d47fafe / Dheeraj Turaga <[email protected]> Fix grid view task ordering by correcting topological_sort implementation The SerializedTaskGroup.topological_sort() method had critical bugs that caused tasks to display in incorrect order in the grid view: 1. Missing logic to check if parent task group dependencies exist before adding nodes to the sorted list, causing premature sorting of dependent tasks. 2. Failed to handle task groups differently from tasks when checking upstream dependencies. Task groups use upstream_group_ids/upstream_task_ids attributes, while tasks use upstream_list. The original implementation only checked upstream_list, causing task groups to appear to have no dependencies. The fix: - Added missing hierarchical_alphabetical_sort() method to support the alternative grid_view_sorting_order configuration option - Fixed topological_sort() to properly detect upstream dependencies for both tasks (via upstream_list) and task groups (via upstream_group_ids/upstream_task_ids) - Added check after the parent task group search loop to break if a dependency was found - Added acyclic flag tracking and handling for cycle/stuck states Updated unit tests to reflect correct topological ordering where tasks appear after their dependencies rather than in arbitrary order. This ensures tasks are displayed in correct dependency order in the grid view, matching how they are executed. Report URL: https://github.com/apache/airflow/actions/runs/18264530553 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
