The GitHub Actions job "Tests" on airflow.git/feature/dynamic-param-config-source has failed. Run started by GitHub user chen0427ok (triggered by jason810496).
Head commit for run: 18d1e139b5cb5f0a1634723b0eccf42509c748e8 / chen0427ok <[email protected]> refactor: Consolidate config loaders and add TypedDict for config_source Address reviewer feedback from jason810496: 1. Consolidate three separate loader functions into single load_options_from_file() - Eliminates duplicated validation logic for file_path, filter_conditions, key_field - Uses 'extension' parameter to specify file format (ini/json/yaml) - Centralizes common logic in helper functions 2. Add TypedDict definition for config_source parameter - Provides clear type hints for IDE autocomplete - Documents expected structure: file, filter, key_field - Improves developer experience and code documentation 3. Remove try-catch for yaml import - task-sdk depends on airflow-core which includes pyyaml - No need for conditional import handling 4. Update all tests to use new unified function - 19 tests for load_options_from_file covering all formats - All tests passing (19 config loader + 4 Param integration) This refactoring follows DRY principle and makes the code more maintainable. Report URL: https://github.com/apache/airflow/actions/runs/20142582348 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
