The GitHub Actions job "Tests" on airflow.git/main has failed. Run started by GitHub user potiuk (triggered by potiuk).
Head commit for run: b7fe72676fadbe3e494d1c368a938aa4a92f0415 / Pradeep Kalluri <[email protected]> Add validation for pool names to prevent InvalidStatsNameException (#59938) * Add Validation for pool names to prevent InvalidStatsNameException Pool names can now only contain ASCII alphabets, numbers , underscores,dots,and dashes to ensure compatibility with stats naming requirments. fixes #59935 * Add unit Tests and news fragment for pool name validation * Fix test file with proper database session handling * Fix test assertions to use pytest.raises match parameter * Add newline at the end of pool.py file * Fix trailing whitespace and quote style in pool.py * Fix syntax error: use consistent double quotes in regex * Add missing newline and __init__.py file * Add missing newline and __init__.py with license * Fix __init__.py with proper license and single newline * Implement pool name normalization for stats reporting Following @potiuk's feedback, changed approach from preventing invalid pool names to normalizing them for stats reporting. Changes: - Replaced validate_pool_name() with normalize_pool_name_for_stats() - Pool names with invalid characters are normalized (replaced with _) when emitting metrics - Logs warning when normalization occurs, suggesting pool rename - Removed validation from create_or_update_pool() - Updated scheduler_job_runner.py to use normalized names for stats - Removed validation tests - Updated news fragment This prevents InvalidStatsNameException without breaking existing pools with invalid names. Fixes #59935 * Implement pool name normalization for stats reporting Following @potiuk's feedback, changed approach from preventing invalid pool names to normalizing them for stats reporting. Changes: - Added normalize_pool_name_for_stats() function in pool.py - Pool names with invalid characters are normalized (replaced with _) when emitting metrics in scheduler_job_runner.py - Logs warning when normalization occurs - Removed validation tests - Removed accidental fix_quote.py file - Updated news fragment This prevents InvalidStatsNameException without breaking existing pools. Fixes #59935 * Add missing 're' module import * Remove duplicate import * Apply CI formatting fixes - import order and blank lines * Fix formatting - add proper blank lines per ruff format requirements Report URL: https://github.com/apache/airflow/actions/runs/20681898039 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
