The GitHub Actions job "Tests" on airflow.git/fix-dag-processor-metrics has 
failed.
Run started by GitHub user nickstenning (triggered by nickstenning).

Head commit for run:
09fc07ddecbe07b3ad8aae7bf1b6dba5115e9857 / Nick Stenning <[email protected]>
Fix broken `dag_processing.total_parse_time` metric

DagFileProcessorManager has been emitting a nonsense value for
`dag_processing.total_parse_time` since 8774f28d76, which reversed the
order in which `emit_metrics` and `prepare_file_queue` (then called
`prepare_file_path_queue`) were called.

As `prepare_file_path_queue` was responsible for resetting the value of
`self._parsing_start_time`, the assumption made by `emit_metrics` was
that it would be called once the file queue had been cleared, but
crucially before `prepare_file_queue` was called to refill the queue.

I've put the order of these calls back to one that generates valid
metrics, and restructured the code in order to make the data
dependencies explicit so that it's harder to make the same mistake in
future refactoring.

Report URL: https://github.com/apache/airflow/actions/runs/22144027367

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to