The GitHub Actions job "Tests" on airflow.git/fix/63965-improve-playwright-variable-spec has failed. Run started by GitHub user tysoncung (triggered by choo121600).
Head commit for run: 46a450ee91ff35ceb719cd66eb837fd36a4db9f2 / Tyson Cung <[email protected]> fix(ui/e2e): improve Playwright test patterns in variable.spec.ts (#63965) Replace Playwright anti-patterns with best practices in variable spec and VariablePage page object. Changes in VariablePage.ts: - Replace page.waitForFunction() with DOM queries with locator-based .or() pattern using web-first assertions - Replace this.table.waitFor() with expect().toBeVisible() - Replace locator('tbody tr') with locator('tbody').getByRole('row') - Replace locator('thead input[type=checkbox]') with locator('thead').getByRole('checkbox') - Replace locator('[id^=checkbox][id$=:control]') with getByRole('checkbox') - Replace locator('tr:has-text(...)') with tableRows.filter({ hasText }) - Replace locator('td:nth-child(2)') with getByRole('cell').nth(1) Changes in variable.spec.ts: - Replace locator('[data-part=backdrop]') with getByRole('dialog') Changes in playwright.config.ts: - Remove variable.spec.ts from testIgnore list closes #63965 Report URL: https://github.com/apache/airflow/actions/runs/23348278935 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
