The GitHub Actions job "Tests" on airflow.git/fix/63966-improve-playwright-xcoms-spec has failed. Run started by GitHub user tysoncung (triggered by choo121600).
Head commit for run: 14d7e91cb6d3f7003b575f7a06427a1dc8ab13aa / Tyson Cung <[email protected]> fix(ui/e2e): improve Playwright test patterns in xcoms.spec.ts (#63966) Replace Playwright anti-patterns with best practices in xcoms spec and XComsPage page object. Changes in XComsPage.ts: - Replace locator('[data-testid="..."]') with getByTestId() (4 occurrences) - Replace locator('[role="menu"]') with getByRole('menu') - Replace locator('[role="menuitem"]') with getByRole('menuitem') - Replace filterMenu.waitFor() with expect().toBeVisible() - Replace filterInput.waitFor() with expect().toBeVisible() - Replace xcomsTable.waitFor() with expect().toBeVisible() - Remove waitForLoadState('networkidle') calls (3 occurrences) - Replace locator('tbody tr') with locator('tbody').getByRole('row') - Replace locator('td') with getByRole('cell') - Replace manual count assertions with not.toHaveCount(0) - Simplify verifyXComDetailsDisplay to use web-first assertions Changes in xcoms.spec.ts: - Replace page.waitForFunction() with DOM queries with locator-based expect().not.toHaveCount(0) closes #63966 Report URL: https://github.com/apache/airflow/actions/runs/23348394684 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
