The GitHub Actions job "Tests" on 
airflow.git/fix-smtp-test-connection-bug-66391 has failed.
Run started by GitHub user jlaportebot (triggered by potiuk).

Head commit for run:
ac5d20bafc1b0151f439b91efa1121857a0fa163 / jlaportebot <[email protected]>
Fix SMTP hook test_connection to handle tuple return value from noop()

Fixes #66391

The test_connection method was incorrectly checking if the return value
from smtp_client.noop() was equal to 250, but smtplib.noop() returns a
tuple (status_code, message), not just an integer. This caused the
connection test to always fail even when the connection was successful.

Changed the check from:
  if status == 250:
to:
  if status[0] == 250:

Also added comprehensive tests to verify the fix works correctly:
- test_test_connection_success: Verifies successful connection test
- test_test_connection_failure_non_250: Verifies failure on non-250 status
- test_test_connection_exception: Verifies exception handling

Report URL: https://github.com/apache/airflow/actions/runs/25456166579

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to