The GitHub Actions job "Tests (AMD)" on 
airflow.git/onikolas/pr1/s3-bundle-version-core has failed.
Run started by GitHub user o-nikolas (triggered by o-nikolas).

Head commit for run:
8f3b424301390984f8ef403c7f4da919d35729a3 / Niko Oliveira <[email protected]>
Address review feedback: fix data loss, extract shared helper, update 
GitDagBundle

Review feedback from potiuk on PR #66491:

1. Fix data loss in dag_reserialize: pass version_data through sync_bag_to_db
   so reserialization preserves BundleVersion.data on DagVersion rows.

2. Extract _unpack_bundle_version from DagFileProcessorManager to module-level
   unpack_bundle_version() in bundles/base.py. Both CLI and manager now use
   the same helper (with deprecation warning for legacy string returns).

3. Migrate GitDagBundle to return BundleVersion on Airflow 3.3+ using
   AIRFLOW_V_3_3_PLUS version guard for backwards compatibility.

4. Tighten BundleVersion.data type to dict[str, Any] | None with mutation note.

5. Fix sa.JSON -> sa.JSON() in dag_version.py for style consistency.

6. Add comment explaining is None vs falsy check in manager.py.

Report URL: https://github.com/apache/airflow/actions/runs/25697809405

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to