The GitHub Actions job "Check newsfragment PR number" on 
airflow.git/fix/65400-heartbeat-callback-type has failed.
Run started by GitHub user 1fanwang (triggered by 1fanwang).

Head commit for run:
818a2810a41e0d1d0a4e091c4b598efe7b6d3cd0 / 1fanwang <[email protected]>
Fix scheduler firing on_failure_callback for heartbeat-timed-out retries

When a worker stops heartbeating (OOMKill, node eviction), the scheduler's
``_purge_task_instances_without_heartbeats`` built a ``TaskCallbackRequest``
without ``task_callback_type``. ``is_failure_callback`` treats the default
``None`` as a failure, so the Dag processor ran ``on_failure_callback`` even
when the task still had retries left — emitting spurious failure alerts for
tasks that ultimately succeeded.

Set ``task_callback_type`` from a direct ``max_tries`` / ``try_number``
check. The canonical pattern elsewhere in the file uses
``ti.is_eligible_to_retry()``, but that helper has a "task not loaded"
fallback (``return self.try_number <= self.max_tries``) that misreports
retry-eligibility for ``retries=0`` tasks when ``ti.task`` isn't eagerly
loaded — which is exactly the case in this code path.

closes: #65400

Report URL: https://github.com/apache/airflow/actions/runs/25737482444

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to