The GitHub Actions job "Check newsfragment PR number" on 
airflow.git/fix/airflow-fail-in-retry-callback has failed.
Run started by GitHub user 1fanwang (triggered by 1fanwang).

Head commit for run:
2627890010f979ee437088747ca67492a4564569 / 1fanwang <[email protected]>
Honor AirflowFailException raised inside on_retry_callback

Raising AirflowFailException is the documented way to fail a task without
retrying. Until now that signal was silently swallowed when raised from
on_retry_callback: the catch-all `except Exception` inside
`_run_task_state_change_callbacks` ate it, the task stayed UP_FOR_RETRY,
and another attempt was scheduled.

The retry path now defers sending its terminal message until after
on_retry_callback has run. If the callback raises AirflowFailException,
the state is promoted to FAILED, the pending RetryTask is replaced with
TaskState(FAILED), and the failure-path finalizers (on_failure_callback,
listener.on_task_instance_failed, email_on_failure) run as if the task
had failed without ever attempting a retry. Other exceptions from
on_retry_callback are still logged and swallowed, so callbacks that
optimistically clean up partial data continue to work unchanged.

closes: #60172

Report URL: https://github.com/apache/airflow/actions/runs/25744108338

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to