The GitHub Actions job "Tests (AMD)" on airflow.git/fix-milestone-tag-assistant-race has succeeded. Run started by GitHub user potiuk (triggered by potiuk).
Head commit for run: 462b2aa902d56c3e2adf16040791b0e08e02ebe5 / Jarek Potiuk <[email protected]> CI: fix milestone-tag-assistant race when labels change post-merge The `milestone-tag-assistant.yml` workflow snapshots PR labels at the `get-pr-info` job (via `listPullRequestsAssociatedWithCommit`) and then spends ~1.5 minutes installing Breeze and running `breeze ci set-milestone`. If a maintainer adds and removes a backport label inside that window, the action commits to the stale-snapshot decision and sets the wrong milestone — see the incident on PR #67301 where a backport label that lived for 49 seconds caused an Airflow-3.2.3 milestone to be set on a `main`-only documentation PR. Re-read `issue.labels` from the freshly-fetched issue before computing the milestone. If the labels changed since the snapshot: - Honour any skip label that appeared after the snapshot. - Re-run `_determine_milestone_version` with the current labels and use the fresh decision; if the decision flips to "no milestone", bail out before posting the comment. Adds three regression tests covering the three race-window cases (backport label removed, replaced, skip label added) and updates two existing happy-path tests to populate `mock_issue.labels` so the re-read sees the same labels as the snapshot. Report URL: https://github.com/apache/airflow/actions/runs/26292162236 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
