The GitHub Actions job "Tests (ARM)" on airflow.git/main has failed.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
530bbb3af576a40b4cc81c0109405ef66a4817e0 / Pierre Jeambrun 
<[email protected]>
Apply note when clearing a Dag Run / task instances (#67639)

* Apply note in one shot when clearing a Dag Run / task instances

Both the single-run and bulk Clear dialogs used to issue two requests:
first ``POST .../clear`` to clear the run / task instances, then a
follow-up ``PATCH .../dagRuns/{run_id}`` or ``PATCH .../taskInstances/...``
to set the note typed in the dialog. That race-prone double-call goes
away here.

``ClearTaskInstancesBody`` already carries a ``note`` field that the
clear endpoint applies via ``_patch_task_instance_note`` in the same
transaction. This commit ports the same convention to
``DAGRunClearBody`` — adding ``note: str | None`` and applying it to
the cleared Dag Run in ``clear_dag_run`` after the clear succeeds.

Semantics match the bulk-update / patch convention:
``note=None`` (the default) leaves the existing note untouched; any
string value (including ``""``) replaces it. Dry-run never writes.

UI changes: ``ClearRunDialog``, ``ClearTaskInstanceDialog`` and
``useBulkClearDagRuns`` now pass ``note`` directly in the clear body
when it changed and drop their secondary ``patchDagRun`` /
``patchTaskInstance`` mutations. Bulk clear of task instances already
followed this pattern and is unchanged.

* Address review feedback

- UI: replace ``...(cond ? { note } : {})`` spreads with a direct
  ``note: <expr> ?? undefined`` / ternary in the request body — same
  serialized output (``undefined`` keys are dropped by JSON.stringify),
  one less object spread.
- Backend: drop the verbose ``description=`` on ``DAGRunClearBody.note``
  so its OpenAPI schema matches the existing patch-body ``note``
  fields. ``datamodel-code-generator`` was emitting two extra
  ``Note2`` / ``Note3`` ``RootModel`` classes purely because the
  description made the Field signature distinct; with it gone, all
  the ``note`` fields collapse back onto the single ``Note`` model
  in ``airflow-ctl/src/airflowctl/api/datamodels/generated.py``.

Report URL: https://github.com/apache/airflow/actions/runs/26659854438

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to