The GitHub Actions job "Tests (AMD)" on airflow.git/fix-table-checkbox-selection-lag has failed. Run started by GitHub user pierrejeambrun (triggered by pierrejeambrun).
Head commit for run: cac9c96b6150d337af0daec673a3f4492c84dbfe / pierrejeambrun <[email protected]> UI: Fix laggy multi-selection checkboxes in tables Clicking a row checkbox caused all rows to re-render because the columns array closed over the selectedRows Map. Each click rebuilt the columns, which TanStack Table treated as a fresh definition and cascaded into a full re-render of every cell — including heavy cells like Time, RouterLink, and the per-row action buttons. With ~30-50 rows that adds hundreds of milliseconds before the checked state appears. Move selection state into a SelectionContext and split the checkbox cells into dedicated SelectionRowCheckbox / SelectionHeaderCheckbox components that subscribe to the context. The columns array no longer depends on selectedRows, so the table only re-renders the checkboxes themselves on each click instead of the whole grid. Also switch the checked prop from selectedRows.get(key) (boolean | undefined) to selectedRows.has(key) (boolean) so the Chakra checkbox stays in controlled mode instead of flipping between uncontrolled and controlled across renders. Applied to all four tables that use multi-selection: TaskInstances, DagRuns, Variables, Connections. Report URL: https://github.com/apache/airflow/actions/runs/27152142403 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
