The GitHub Actions job "Tests (AMD)" on airflow.git/fix_65505 has succeeded.
Run started by GitHub user cmettler (triggered by eladkal).

Head commit for run:
b944be61a0af1249d67eef768493bc2845838b99 / Christoph 
<[email protected]>
Scope process-group handling to the task runner and guard kill() against 
self-signalling

Review feedback on #65738: os.killpg(os.getpgid(child)) trusted that the
child had already run setsid() -- if setpgid failed or kill() ran before
the child was first scheduled (task_instances.start() raising
synchronously), getpgid resolved to the supervisor's own group and
killpg would have signalled the supervisor and all its siblings, with no
exception for the fallback to catch.

Use a plain process group (setpgid, matching
airflow.utils.process_utils.set_new_process_group) instead of a new
session, set it from both sides of the fork so the group exists as soon
as start() returns, refuse to killpg our own group, and make the whole
behaviour opt-in per subclass (like use_exec) so the DAG processor,
triggerer and callback subprocesses keep direct signalling. The graceful
SIGTERM-forwarding path now also signals the group, closing the same
orphan leak on e.g. K8s pod termination.

Report URL: https://github.com/apache/airflow/actions/runs/28716166169

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to