The GitHub Actions job "Tests (AMD)" on 
airflow.git/fix/alibaba-maxcompute-noop-assertion has succeeded.
Run started by GitHub user anxkhn (triggered by potiuk).

Head commit for run:
7ca535fc59ece124c259206016038684fb54ec54 / Anas Khan 
<[email protected]>
Fix no-op assertion in MaxCompute run_sql test

The test asserted `mock_client.run_sql.asssert_called_once_with(...)` with a
misspelled `asssert`. On a MagicMock that attribute is auto-created, so calling
it returns a truthy mock and the wrapping `assert` always passed, leaving the
hook's argument forwarding to `client.run_sql` unverified, including the branch
that derives `priority` from the `odps.instance.priority` hint.

Use the real `assert_called_once_with` and parametrize the test to cover
explicit priority, priority derived from hints, and no priority so the forwarded
arguments are actually checked.

Signed-off-by: Anas Khan <[email protected]>

Report URL: https://github.com/apache/airflow/actions/runs/28733367607

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to