Hello Johannes

Thanks for your feedback

> I've taken a look at the "FactoryProxy". IMHO it's a good approach but
> during a request it seems that it's very likely that the internal
> factory delegate gets created many many times. This may not be a
> dramatic performance penality but should be avoided. The client of the
> "FactoryProxy" even has no chance to avoid the permanent creation of
> the underlying FactoryOperations.

Agreed, it is not yet optimal, and thus marked as "EXPERIMENTAL"

> Hopefully the existing factories get refactored soon to accept a
> DataSource, hence the factories can be created once and be used
> accross application code.

I hope so, too.

> [... code ...]
> Maybe this could be helpful for others too.

Thanks for sharing this. I'm curious about feedback by others!

> When I've got some time left I will try to synchronize (like Spring's
> DataSourceUtils does it for a Connection) the created factory with the
> current Spring-managed transaction (if any) so it only needs to be
> created once during a transaction.

Thanks for this contribution. Feel free to provide a pull request on
GitHub, potentially modifying the current FactoryProxy
https://github.com/jOOQ/jOOQ

Cheers
Lukas

Reply via email to