> getNewFactory() smells because it works mostly on fields of the
> Configuration instance. [...]

Agreed. The Factory <-> Configuration relationship grew organically.
I'm not entirely happy with it, myself.

> So my preferred constructor would look like:
>
> Factory(Configuration)
>
> I'll try to implement this and send you a pull.

Looking forward to seeing that.

Reply via email to