Hi Peter, 2013/4/12 Peter Ertl <[email protected]>: > Hi Lukas, > > first of all thanks for the decent amount of quality work going on at > 3.0.0-SNAPSHOT.
You're welcome! ... mails starting out with compliments make me suspicious, ;-) > Since you already did some renames on classes for good I would suggest to > also rename class 'Configuration'. > Maybe to 'DSLConfiguration' / 'JOOQConfiguration' / 'JooqConfiguration' / > 'DatabaseConfiguration' or whatever you think is appropriate. > > Why? > > - 'Configuration' is a heavily overused name in many frameworks (even used > several times in standard java runtime library). Chance of a name clash is > high. > - The name could basically just mean anything but doesn't give you the > slightest idea (besides the package name) it's related to Jooq, databases or > sql. > > I attached a screenshot showing the many 'Configuration's I already get on a > not to fancy project for demonstration. I think that org.jooq.Configuration is a very good name for what this type intends. It configures jOOQ's behaviour. Name clashes are OK, that's what packages are for. Some languages built on top of the JVM allow for local imports (e.g. Scala), or import renames (e.g. Scala, Ceylon). I'm open to concrete suggestions, though. However, please disregard suggesting prefixes like JOOQXXX. This only makes sense if ALL types are prefixed the same way, and even then, I wouldn't like that... Cheers Lukas -- You received this message because you are subscribed to the Google Groups "jOOQ User Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
