Hi Lukas, got it - I adjusted it on our side. Thanks for making that (breaking) change for the better. 👍
Johannes On Tue, 1 Dec 2020 at 10:11, Lukas Eder <[email protected]> wrote: > Hi Johannes, > > But why do you need to clean it up? The whole point of this (incompatible) > change is that people called close() on non-resourceful DSLContext > instances all the time, like you're doing right now. Your cleanup call does > not have any effect. > > Maybe, the issue description of the change helps explain this? > https://github.com/jOOQ/jOOQ/issues/10512 > > Thanks, > Lukas > > On Tue, Dec 1, 2020 at 12:45 AM Johannes Bühler <[email protected]> > wrote: > >> Hi Lukas, >> I created a simplified example similar to what we have in our codebase. >> You can find the working example here >> <https://github.com/jonnybbb/jOOQ-mcve/tree/autoclosable_context>. It >> basically narrows down to the usage of the spock.lang.@AutoCleanup usage >> as you can see in BaseDBTest.groovy >> <https://github.com/jonnybbb/jOOQ-mcve/blob/98845c8721f773047870bb0d8ba04ad4ec0ddb72/src/test/groovy/org/jooq/mcve/groovy/BaseDBTest.groovy#L11-L11> >> Let >> me know if you need more details. >> >> Thanks >> Johannes >> >> >> >> >> >> On Mon, 30 Nov 2020 at 09:45, Lukas Eder <[email protected]> wrote: >> >>> Hi Johannes, >>> >>> Can you please show what you're doing (in code) and why you're expecting >>> the things you're expecting? >>> >>> Thanks, >>> Lukas >>> >>> On Sat, Nov 28, 2020 at 1:15 PM Johannes Bühler <[email protected]> >>> wrote: >>> >>>> In 3.14.x the DefaultCloseableDSLContext has been introduced and the >>>> DefaultDSLContext is not autocloseable anymore. We are using the >>>> Autoclosable capabilties within our tests to ensure a clean shutdown. In >>>> the previous JOOQ version 3.13.x we used the DSL.using(Configuration) api. >>>> Is there an Autoclosable equivalent in 3.14.x or is it planned to add a new >>>> constructor DefaultCloseableDSLContext(Configuration)? >>>> >>>> I am happy to create an Issue for that and provide a PR if that's the >>>> way to go. >>>> >>>> Thanks. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "jOOQ User Group" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jooq-user/38464b74-de2e-4f96-a9c3-56d39f5caff1n%40googlegroups.com >>>> <https://groups.google.com/d/msgid/jooq-user/38464b74-de2e-4f96-a9c3-56d39f5caff1n%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "jOOQ User Group" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jooq-user/CAB4ELO48q3ij3jNg5uF_ZuQ6yGRSqtx%2BD6%3DaZ8j7a5rM%2BP-dFw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/jooq-user/CAB4ELO48q3ij3jNg5uF_ZuQ6yGRSqtx%2BD6%3DaZ8j7a5rM%2BP-dFw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> >> Johannes Bühler >> Senior Software Engineer >> Gradle >> W. gradle.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "jOOQ User Group" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jooq-user/CAL_ciTLPTL4OJ8nOy%2BTcaCB-JnScZ5fp18Ja1U6ABe8KHZKyRQ%40mail.gmail.com >> <https://groups.google.com/d/msgid/jooq-user/CAL_ciTLPTL4OJ8nOy%2BTcaCB-JnScZ5fp18Ja1U6ABe8KHZKyRQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "jOOQ User Group" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jooq-user/CAB4ELO4Gdt_mgqneDYE%2B4QmHvq4kvkngunrA2docPduCqXCJ_g%40mail.gmail.com > <https://groups.google.com/d/msgid/jooq-user/CAB4ELO4Gdt_mgqneDYE%2B4QmHvq4kvkngunrA2docPduCqXCJ_g%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Johannes Bühler Senior Software Engineer Gradle W. gradle.com -- You received this message because you are subscribed to the Google Groups "jOOQ User Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/CAL_ciTKEOJ7%3DV6kZN-BDLrwzURg22Gvrb6Rne21sQ0-FwXBf6A%40mail.gmail.com.
