Hi, >>> You mean I should use public fields? Well, the access methods *is* the >>> correct way :-) but on the other hand it's such a simple "record class" >>> so public fields are probably ok here.
>> No, actually not. I do think we should clean up josm code sooner or later. >> I really encourage to use the proper java way and completely omit public >> fields ;-) > Ah, ok. Please do not flood JOSM with getters and setters. If anyone wants to completely clean up JOSM they are free to do it - I agree that an architectural review would make sense - but I would not like a mix of the "traditional JOSM way" and the "textbook Java way" in the code. The textbook Java way is to use getters and setters unless this is not possible for some reason - even if you cannot imagine any situation where they might be needed. The traditional JOSM way is to use public members unless getters and setters are required right now. Bye Frederik _______________________________________________ josm-dev mailing list [email protected] http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
