Petr Dlouhý schrieb:
> Hello,
> 
> you didn't change YAHOOGrabber to adjust your changes, is it? If no, I  
> will change it myself.

That's right. You have to change YAHOOGrabber, too, so that it can be
executed byte the ExeceutorService.

> I had "synchronized (layer) { //download only one tile in one moment" in  
> the code, so only one tile was downloaded at same time. That was, because  
> I didn't know about thread pool, so I think, it could be removed now, is  
> it?

If you added that to avoid too many threads, you can savely remove it.
As I wrote in the other mail, a pool size of 3 worked best for me (with
the server I am using).

> 
> On Fri, 12 Sep 2008 16:10:08 +0200, Henrik Niehaus <[EMAIL PROTECTED]>  
> wrote:
> 
> That's no problem for me. It's only a small patch; nothing to speak of.
> 
> Petr Dlouhý schrieb:
>>>> On Fri, 12 Sep 2008 15:32:38 +0200, Henrik Niehaus
>>>> <[EMAIL PROTECTED]> wrote:
>>>>
>>>> I will take more detailed look at the patch today.
>>>> Do you really want me to commit your patch? I have no problem with that,
>>>> but it will be commited under my name.
>>>>
>>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>>> Hash: SHA1
>>>>>
>>>>> Petr Dlouhý schrieb:
>>>>>
>>>>> I did some more research and the wms server I am using, seems to allow
>>>>> only a few connections from one client. I achieved the best reliability
>>>>> with a thread pool size of 3, so that only 3 connections exist at a
>>>>> time. With this configuration I could scroll around like a berserk and
>>>>> all tiles loaded on the first attempt. So, if you want to apply my  
>>>>> patch
>>>>> to the plugin you should consider to set the pool size to 3.
>>>>> It might be slower with servers, which accept more connections, but it
>>>>> increases the speed at crappy servers, because tiles are loaded
>>>>> immediately and don't need 5 or more http requests.
>>>>>
>>>>> Did you have a look at the patch?
>>>>>
>>>>> Greetings
>>>>> Henrik
>>>>>
>>>>> - --
>>>>> Mein öffentlicher PGP Schlüssel und Fingerabdruck:
>>>>> http://hampelratte.org/pgp/
> 


_______________________________________________
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev

Reply via email to