On Mon, 14 Nov 2011, Valeriy Pekarskyy wrote:
Actually the question is whether anyone have any objections for such
big changes to one plugin. As I am not an author of PicLayer, I do not
feel to do such modification without consulting with anyone, and do
not feel OK to do a fork of the plugin, but I have possibility to do
that svn commit :)
First a note: I don't use these plugins myself.
PicLayer as well as ImportImage plugin (see Frederiks post) seems to have
some problems, but generally the image import seems to be important to a
lot of people, so anyone improving this field is highly appreciated.
According to Trac the owner of PicLayer is "team", which actually means
"nobody".
Regarding your changes (where I did not read the code):
a) If your changes improve the situation without breaking the workflow
totally or dropping features without need: Go on.
b) If you rework everything only to make it different: Stop
From your mail I assume option a) is right here, correct?
Patch file is not good way to deliver such changes - some files were
deleted, some added, and changes touch nearly whole source of the
plugin.
Well, that's what I meant. A diff shows how BIG your changes really are.
If you adopt PicLayer, I would be happy to reassign the bug-report
ownership :-) To many plugins have "team"-ownership.
P.S.: Piclayer has 26 reports currently:
http://josm.openstreetmap.de/query?status=new&component=Plugin+piclayer
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
_______________________________________________
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
