On Tue, 10 Jan 2012, Jiri Klement wrote:
I have hudson running at my laptop that builds josm and plugins and
also checks for changes in josm that breaks backward compatibility
with plugins. Problem is that it's broken all the time (either
compilation error in plugins or some change in josm that breaks some
plugins) so I basically gave up and rarely fix found errors.
:-) This is the disadvantage of the open plugin model we have.
But usually the required fixes are small and it seems lately I need to fix
them always in batch mode when I do I18n updates for plugins.
Theoretically the author doing relevant reworks in core should do plugin
updates.
What I miss in JOSM is FindBugs - it can find lots of stupid errors
automatically (like possible NullPointer exceptions, calling equals on
object of different type, ...). It's already possible to run Find bugs
on JOSM (and I sometimes do it), but for it to be really useful, it's
also necessary to use annotations - it finds lots of false positives
so FindBugs version of @SupressWarning is needed and also FindBugs can
find much more errors if hints like @CheckForNull, @NonNull,
@OverrideMustInvoke are used.
So what do you think about introducing FindBugs annotations? They
doesn't have any effect on built jar, but they can clutter the code a
bit.
I think that depends on the number of such annotations. If the code is
unreadable afterwards, then no, otherwise any support to fix problems is
good.
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
_______________________________________________
josm-dev mailing list
[email protected]
http://lists.openstreetmap.org/listinfo/josm-dev
