Hello, > As far as I understand SideButton is intended to be used with the right > hand dialogs, so the icons don't take up that much space. Everything > that SideButton does is resize them to 20 pixels and offer some random > convenience features (however, in core all but FilterListDialog use the > new SideButton(Action) constructor). > > I can see why we want smaller icons in the sidebar dialogs; but I don't > see why we want them in the save or download dialog. Is there any reason > to this or is this simply a coding error?
Probably someone wanted small buttons also elsewhere? > If it's a coding error, maybe it's possible to assert that > SideButtons are only used in ToggleDialogs. I have no strong feelings against using them. But for dialogs we have ExtendedDialog. Shouldn't this already provide a standard? > Furthermore, if we want 20px icons and 24px icons, we should either ship > them or switch to SVG. This will probably increase the size of josm.jar, > is this a problem? JOSM now supports SVG, so this is probably possible. But switching icons must be tested. It is not sure, that a 20x20 SVG generated icon looks better than a downscaled 24x24 png. Ciao -- http://www.dstoecker.eu/ (PGP key available) _______________________________________________ josm-dev mailing list [email protected] http://lists.openstreetmap.org/listinfo/josm-dev
