OK, John! Done! (http://dev.jquery.com/ticket/3784)
Thanks, Diogo On Mon, Jan 5, 2009 at 12:03 PM, John Resig <[email protected]> wrote: > > Might be good to look in to for a later release. You should file this > in the jQuery bug tracker: > http://dev.jquery.com/ > > --John > > > > On Mon, Jan 5, 2009 at 5:36 AM, Diogo Baeder <[email protected]> > wrote: > > Hi there, > > > > I'd like to propose a performance improvement to the "static method" > > jQuery.grep (1 code line and 1 comment line, just that): > > > > $.grep = function(elems, callback, inv) { > > // Returns using JS 1.6 native code, if appliable > > if (Array.prototype.filter && !inv) return > elems.filter(callback); > > > > var ret = []; > > > > // Go through the array, only saving the items > > // that pass the validator function > > for ( var i = 0, length = elems.length; i < length; i++ ) > > if ( !inv != !callback( elems[ i ], i ) ) > > ret.push( elems[ i ] ); > > > > return ret; > > }; > > > > > > If the client code doesn't use the "invert" argument, and the browser > > implements Array.prototype.filter, we can use the native method, since > the > > signatures for this one and the $.grep callback are the same. > > > > The difference - using 1000 iterations, and filtering a 1000 element > array > > in each one -: > > - Old implementation: 929 ms > > - New implementation: 812 ms > > > > > > Conclusion: not that much of a performance boost, but as it's just 1 line > of > > code, maybe it's worth it... what do you guys think? > > > > -- > > Diogo Baeder > > http://www.diogobaeder.com.br > > > > > > > > > > > -- Diogo Baeder http://www.diogobaeder.com.br --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
