Phew - this is a beast of a patch indeed! In general though I'm liking the feel of the resulting code, a lot. This would be much more extensible, which is quite nice. I say we try to pursue this post-1.4.
In the meantime you can start to apply some of the jQuery Core Style Guidelines to your code to get it ready for inclusion: http://docs.jquery.com/JQuery_Core_Style_Guidelines Naturally, making sure that all the tests pass as well is a great way to make sure that the code lands. --John On Tue, Dec 1, 2009 at 8:21 PM, Julian Aubourg <aubourg.jul...@gmail.com> wrote: > Thanks Dave but I think I kinda figured it out! > > Anyway, the code has been comitted at http://github.com/jaubourg/jquery > > I don't have time to write everything about it down right now but you can > all have a look at least. > > 2009/12/2 Dave Methvin <dave.meth...@gmail.com> >> >> > OK, so I have implemented my solution: >> >> > Anyway, for the time being, my branch is sitting on my harddrive. Why? >> > Well, >> > I've been practicing source control for years now but I have to admit I >> > never encountered something as cryptic and unfriendly as git. >> >> > So, if anyone has clear step in order to commit with this zealot, please >> > do >> > share before I commit suicide. I made a fork of jQuery on github btw. >> >> Julian, I'm still coming up to speed with Git on Windows myself, and >> stuck at trying to push my changes back to my fork on Github. I'm >> going to start a new thread here about it. >> >> -- >> >> You received this message because you are subscribed to the Google Groups >> "jQuery Development" group. >> To post to this group, send email to jquery-...@googlegroups.com. >> To unsubscribe from this group, send email to >> jquery-dev+unsubscr...@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/jquery-dev?hl=en. >> >> > > -- > > You received this message because you are subscribed to the Google Groups > "jQuery Development" group. > To post to this group, send email to jquery-...@googlegroups.com. > To unsubscribe from this group, send email to > jquery-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/jquery-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-...@googlegroups.com. To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en.
