I just landed your change: http://github.com/jquery/jquery/commit/209751fcbd8a42eef68df44c875763b6af8a5474
The best way to get further changes in is to make a fork of jQuery on Github, commit your changes to your fork, and then do a pull request. I'll see that right away and will be able to help you. It's also generally a good practice to have tickets to go along with your changes so that we can tie it back to a central point of discussion. Thanks for your help! --John On Mon, Dec 21, 2009 at 4:19 PM, alexander farkas <a.farkas...@googlemail.com> wrote: > This is great. I ´m awaiting jQuery 1.4 eagerly. : -). After I wrote > the script I found two bugs in my script. Didn´t know, that you > already grabbed the code. But you only corrected one of them. > > change the following line in the beforeactivate-handler: > return jQuery.data( elem, "_change_data", getVal(elem) ); > > to something like this: > > jQuery.data( elem, "_change_data", getVal(elem) ); > //for FF strictmode, if you want (code won´t be ever run in ff): > return undefined; > > If you leave it, the other way and the data for a unchecked checkbox > is collected, the event will be prevented, wich breaks keyboard > handling. > > + One other thing: > > I would build the new jQuery-Version and make some more tests on this, > using your delegatetest.html. If i find something, should I fill a > bug, add the fix in this post or what is your preferred way? > > > On 21 Dez., 21:34, John Resig <jere...@gmail.com> wrote: >> I poured over your patch all morning/afternoon and made a number of >> changes, but finally landed it in jQuery >> core:http://github.com/jquery/jquery/commit/5dc6b7ce3469eaadb37a151d449e8d... >> >> We now completely override the change event in IE, even for binding to >> form elements. This gives us full parity with other browsers (yay!). >> >> Thanks again, Alexander! >> >> --John >> >> On Mon, Dec 21, 2009 at 9:52 AM, alexander farkas >> >> <a.farkas...@googlemail.com> wrote: >> > the url to the testcase, fix and diff: >> >http://www.protofunc.com/scripts/jquery/change-event/fixed-change.html >> >> > On 21 Dez., 15:50, alexander farkas <a.farkas...@googlemail.com> >> > wrote: >> >> I looked in the current implementation of the change event and found >> >> some bugs in the IE specific code. The most obvious bugs were: >> >> >> 1. change-event bugs in conjunction with live: >> >> - the change event on radios happens to early (before the state is >> >> changed to checked) >> >> - the change event on radios also occurs, if the user only focuses it >> >> without changing it´s state (keyboard navigation or but untestet >> >> readonly-property) >> >> - the change event occurs also on disabled/readonly checkboxes >> >> - the change event on text-input and textarea never occurs >> >> (reason:http://groups.google.com/group/jquery-dev/browse_thread/thread/270483...) >> >> >> 2. change-event bugs in conjunction with bind >> >> - most change events are doubbeld (normal change + computed change >> >> including the bugs mentioned above) >> >> >> I tried to fix these issues you can find the demos + an uniffied diff >> >> @http://www.protofunc.com/scripts/jquery/change-event/fixed- >> >> change.html >> >> >> To see the difference you have to use IE (6-8) with a console.log. >> >> >> Due to the fact, that the change-event in IE is vehemently broken. We >> >> can completely intercepting it. This also allowes us to not only fix >> >> the ovbious things like the bad change event on checkboxes/ >> >> radiobuttons. it also allowes us to fix the accessibility issue with >> >> the change event on select-elements. >> >> >> The code is a quickfix so it needs a little love. >> >> > -- >> >> > You received this message because you are subscribed to the Google Groups >> > "jQuery Development" group. >> > To post to this group, send email to jquery-...@googlegroups.com. >> > To unsubscribe from this group, send email to >> > jquery-dev+unsubscr...@googlegroups.com. >> > For more options, visit this group >> > athttp://groups.google.com/group/jquery-dev?hl=en. > > -- > > You received this message because you are subscribed to the Google Groups > "jQuery Development" group. > To post to this group, send email to jquery-...@googlegroups.com. > To unsubscribe from this group, send email to > jquery-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/jquery-dev?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-...@googlegroups.com. To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en.
