Thanks for the suggestion Matt. Landed it here:
http://github.com/jquery/jquery/commit/6cb2945837ccca55204191a8e7a70b2b2486c28e
Looking at the new numbers I see:
Without patch: 19763200
With patch: 19910656
So still about a 1/5MB increase in memory usage.
--John
On Thu, Dec 31, 2009 at 8:53 AM, Matt <m...@thekrusefamily.com> wrote:
> On Dec 30, 10:58 pm, John Resig <jere...@gmail.com> wrote:
>> Interesting, I've, also, seen the = null; proposal before, but not the
>> = function(){}; one. Doing some poking around I found mention of it
>> here:http://www.ilinsky.com/articles/XMLHttpRequest/#bugs-ie-leak
>
> I haven't inspected the jQuery ajax code much, but what you changed is
> not what this link recommends.
> They say:
> self.object.onreadystatechange = new Function;
> whereas you have done:
> xhr.onreadystatechange = function(){};
>
> Those are two very different things!
>
> You've created an anonymous function with a scope chain that includes
> the xhr object, etc. You need to do something like
> jQuery.noop = function(){};
> and set
> xhr.onreadystatechange = jQuery.noop;
>
> Matt Kruse
>
> --
>
> You received this message because you are subscribed to the Google Groups
> "jQuery Development" group.
> To post to this group, send email to jquery-...@googlegroups.com.
> To unsubscribe from this group, send email to
> jquery-dev+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/jquery-dev?hl=en.
>
>
>
--
You received this message because you are subscribed to the Google Groups
"jQuery Development" group.
To post to this group, send email to jquery-...@googlegroups.com.
To unsubscribe from this group, send email to
jquery-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/jquery-dev?hl=en.
