Both reasonable requests - landed the changes: http://github.com/jquery/jquery/commit/6cf981eea20695987b4f7341f80442a7cf8271eb
Thanks! --John On Thu, Dec 31, 2009 at 4:39 AM, candlerb <b.cand...@pobox.com> wrote: > On Dec 31, 3:29 am, John Resig <jere...@gmail.com> wrote: >> Umm, hmm - &> is perfectly valid shell - used for redirecting both >> stdout and stderr >> simultaneously:http://www.gnu.org/software/bash/manual/bashref.html#Redirectionshttp://dsl.org/cookbook/cookbook_5.html#SEC57 > > Yes, but not all shells are bash, and bash implements a ton of > extensions beyond POSIX. > > The default shell in Ubuntu is dash: "Only features designated by > POSIX, plus a few Berkeley extensions, are being incorporated into > this shell" [from the manpage] > > BSD users are also likely to be affected if you rely on bash features. > > The POSIX way to redirect both stdout and stderr is: >/dev/null 2>&1 > >> Also - why is there an empty src/sizzle directory? That shouldn't be >> there to begin with > > Well I'm not sure. Maybe I typed 'make' before 'make init' when I > first downloaded. But it could also be because of the '&' > backgrounding, because the makefile would continue executing before > the git clone had completed. > >> Deleting it isn't really desired since that would do a >> complete, fresh, clone every single time a build is done > > But I'm only deleting it if it's entirely empty: rmdir will fail if > the directory has any contents. > > Perhaps a better solution is to change > > @@if test ! -d src/sizzle; then git clone ,,, > > to > > @@if test ! -d src/sizzle/.git; then git clone ... > >> We're intentionally not using git submodules because the submodules >> need to be constantly re-synced with the HEAD of the other project > > Fair enough, I can see that's annoying if the other project is fast- > moving too. > > Submodules would have the the advantage that if someone says they have > checked out commit XXXX of jquery, and can demonstrate a bug, you will > be able to reproduce it directly; otherwise they have to tell you the > commit IDs of jquery *and* sizzle etc. > > Regards, > > Brian. > > -- > > You received this message because you are subscribed to the Google Groups > "jQuery Development" group. > To post to this group, send email to jquery-...@googlegroups.com. > To unsubscribe from this group, send email to > jquery-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/jquery-dev?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-...@googlegroups.com. To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en.
