Joel Birch wrote:
This looks awesome Dave. I like that it is a more "finished" product than my plugin so there is less left to the developer to do to get it working and looking great.
Not so sure about more finished, but thanks. You code helped a lot, but much of it was beyond my current understanding -- one day :)

I also like that you can see the hierarchy of headings in the list. Currently you are using CSS to emulate the look of nested lists. Would it be better if the list of links had more sematics ie. actual nested ordered (maybe unordered) lists rather than a string of anchor tags within a div?
In this case, I'm not sure what the added sematics would buy. Particularly when compared to the slight increase in code where we'd need to track opening and closing list tags. Especially if headers are not in strict H1, H2, H3 order, and were H1, H3, H2. The way it currently works is to simply increase the margin to obtain the appropriate indent.

The code is nice and brief and looks pretty optimal, good job.
Again, thanks.

Reply via email to