Just a side note, that will probably crash IE. IE doesn't like to
delete things from elements.

--
Brandon Aaron

On 5/24/07, John Resig <[EMAIL PROTECTED]> wrote:

What if you straight-out delete the property?
$(...).find("*").each(function(){ delete this.mergeNum; });

Having the value come up as mergeNum="null"  tells me that there's
something very wrong at play here. What exactly are you using to
serialize the contents of the designMode area?

--John

On 5/24/07, Jean-Francois Hovinne <[EMAIL PROTECTED]> wrote:
>
> Thanks for your quick reply, John, and sorry for annoying you with
> that issue, but it seems to be a major blocker for WYMeditor to work
> correctly with jQuery in MSIE.
>
> I did test the fix you propose (this.mergeNum = null).
> The attribute is still there, i.e. mergeNum="null" for each element.
>
> This isn't the only problem.
> WYMeditor uses designMode, and (I don't know exactly why) MSIE
> sometimes creates extra DIVs when mergeNum attr is present, while
> editing.
> The HTML code quickly becomes ugly and difficult to clean up.
>
> Thus Volker's patch seemed to be a good solution.
>
> Thanks,
> Jean-François
>
> On 24 mai, 22:10, "John Resig" <[EMAIL PROTECTED]> wrote:
> > Did you test it against the test suite? And did you test it for speed
> > changes? The reason why this is being done, in the first place, is
> > purely for speed reasons. Added extra checks or loops significantly
> > slows down the speed of jQuery selectors. The mergeNum technique is
> > the fastest means of checking for unique-ness in a set of elements. If
> > you can find a method that's just as fast, but doesn't have the
> > property, then we'll by all means use it.
> >
> > Additionally, while your patch does change some things around, it
> > doesn't change the fact that the mergeNum property will still be added
> > to some elements, thus still effecting applications like Wymeditor. It
> > just doesn't happen in this very specific case (which is what your
> > patch is attempting to work around).
> >
> > My suggestion would be to add the following code to Wymeditor to
> > remove the property:
> > $(...).find("*").each(function(){ this.mergeNum = null; });
> >
> > I mentioned this before, but I still think it's the best solution.
> > It's a very specific problem with a very specific solution.
> >
> > --John
> >
>
>

Reply via email to