Hi Artem,
> I've tried ui.spinner and i find it very useful.
>
Thanks. I'm glad you found it useful. :)
>
> Here are couple of things I've changed to make it work better for my
> project (below are chunks from diff my.ui.spinner.js ui.spinner.js):
>
> 1. Making mousewheel trigger 'spinchange' event:
>
> 156d155
> < self._propagate('change', e);
>
> It is kinda useful to make a single event being in charge of all
> spinner changes. No need to think twice on ajax binding.
Yes, this was implemented after the 1.6rc2 release in r743, see:
http://ui.jquery.com/bugs/changeset/743
We set a timer on the mousewheel trigger as spinchange should only fire
*after* increment/decrement completes not while it's looping.
>
>
> 2. Fixing of this bug:
> > Cloudream wrote:
> > Press on one button, move your mouse out, then release your mouse, the
> > spinner won't stop.
>
> was not too accurate since 'mouseout' event now triggers 'spinchange'.
> Which in case of ajax binding costs a useless server call and makes it
> particulary confusing when you want visualize ajax call progress/
> result (e.g. progress indicator and so on).
> I didn't bother with a proper solution, but here is a quick hack:
> 54c54
> < self._mouseup(e, true);
> ---
> > self._mouseup(e);
> 93c93
> < self._mouseup(e, true);
> ---
> > self._mouseup(e);
> 197c196
> < _mouseup: function(e, do_propagate) {
> ---
> > _mouseup: function(e) {
> 201,202c200
> < if (do_propagate)
> < this._propagate('change', e);
> ---
> > this._propagate('change', e);
>
>
Could you create a ticket and attach a patch for review? You could create a
new ticket at http://ui.jquery.com/bugs/newticket (note: you need to
register before you could create a ticket).
Thanks for your contributions.
--
Ca-Phun Ung
+ http://yelotofu.com
+ hongkong, zce, jquery, php, css, html
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"jQuery UI" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/jquery-ui?hl=en
-~----------~----~----~----~------~----~------~--~---
