Updated again:

- Modified to use an inner class instead of anon, so that...
- Result of executing script in-process is now saved and set/returned as appropriate for $? and result of Kernel#system call

Running Rake with this currently *does* launch scripts in process (yay!) but fails deeper in due to some weird block arg bug I haven't pinned down yet. The script patch seems pretty solid though, and I confirmed that the block arg bug shows up when running the in-process scripted command directly as well. I think the in-process script patch may be good enough at this point to commit it.

We could use some good test cases though...

On 4/6/06, Charles O Nutter <[EMAIL PROTECTED]> wrote:
I suppose I could have just made these changes before sending the last patch...

This updated version propagates the incoming streams through the interpreter, so that for MVM if you pass in in, out, and err they'll actually be used in that VM as Ruby's stdin, stdout, and stderr streams. With this additional change the rogue writes are eliminated. I'm going to move on to trying out Rake.

--
Charles Oliver Nutter @ headius.blogspot.com
JRuby Developer @ jruby.sourceforge.net
Application Architect @ www.ventera.com

Attachment: main_commandlineparser_cleanup_plus_inprocess_scripts.patch
Description: Binary data

Reply via email to