Christopher Williams wrote: > Thomas and Charles, > I've been bad and haven't been subscribed to your development > mailing list (I'm the RDT developer) - but I ran into some archives > with questions and patches flying around by the Swiss students doing > refactoring work. > > I had a few questions and comments. Have any of the patches that the > students come up with made their way back into the trunk of JRuby? > > Beyond what I saw from them, I've run into some wishes as I worked on > RDT that I filed away as TODOs (and hadn't gotten to). One of which > was handling and returning the comments from the source. It's be > really, really nice to have CommentNodes with the text of the > comments.There's no way to get at them from the AST, and in the past > it seemed to mess up positioning (by eating up newlines) of nodes > after comment blocks where the line only contains a comment. > > Also, I noticed that strings are decomposed into a strange AST. Many > strings get decomposed to something like StrNode -> DStrNode -> > DStrNode - even for a simple single-quoted string. > > This email is mainly just to get in touch, get up to date and start > the conversation so I can start working on trying to get a newer JRuby > integrated for our next release. > > Thanks, > Chris Hi Chris
I'm the guy who is mainly involved in the comment thing. Actually I've never provided a patch which contained any of the changes which handle the comments. As I'm still trying to deal with the assignment of the commentNodes in special cases and the new nodes will have to be tested properly, it will take some time until the comment changes are submitted. Actually we might have some interesting input about the latest JRuby version in RDT. We managed to adapt RDT to work with JRuby 0.8. But there are still some issues with the positions of the outline items. When Mirko has managed to fix all the positions we might have a look at this. Having a quick look at the positions in the outline frame we came across a method which seems to correct the wrong positions of the JRuby-AST-Nodes. If all the positions are correct we possibly won't need this method anymore. If you have any further questions feel free to ask. Greetings Thomas C. _______________________________________________ Jruby-devel mailing list Jruby-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jruby-devel
