Title: [826] trunk/activerecord-jdbc:
Fix Derby quote_column_name issue by #to_s on the column name up front.
- Revision
- 826
- Author
- nicksieger
- Date
- 2007-12-05 15:05:44 -0500 (Wed, 05 Dec 2007)
Log Message
Fix Derby quote_column_name issue by #to_s on the column name up front.
Not sure why this only failed on trunk...
Modified Paths
Diff
Modified: trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_derby.rb (825 => 826)
--- trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_derby.rb 2007-12-01 12:49:12 UTC (rev 825)
+++ trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_derby.rb 2007-12-05 20:05:44 UTC (rev 826)
@@ -337,6 +337,7 @@
# For DDL it appears you can quote "" column names, but in queries (like insert it errors out?)
def quote_column_name(name) #:nodoc:
+ name = name.to_s
if /^references$/i =~ name
%Q{"#{name.upcase}"}
elsif /[A-Z]/ =~ name && /[a-z]/ =~ name
Modified: trunk/activerecord-jdbc/src/java/jdbc_adapter/JdbcDerbySpec.java (825 => 826)
--- trunk/activerecord-jdbc/src/java/jdbc_adapter/JdbcDerbySpec.java 2007-12-01 12:49:12 UTC (rev 825)
+++ trunk/activerecord-jdbc/src/java/jdbc_adapter/JdbcDerbySpec.java 2007-12-05 20:05:44 UTC (rev 826)
@@ -287,7 +287,7 @@
Ruby runtime = recv.getRuntime();
try {
IRubyObject conn = rubyApi.getInstanceVariable(recv, "@connection");
- String sql = rubyApi.convertToRubyString(args[0]).toString().trim().toLowerCase();
+ String sql = args[0].toString().trim().toLowerCase();
if (sql.charAt(0) == '(') {
sql = sql.substring(1).trim();
}
_______________________________________________
Jruby-extras-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/jruby-extras-devel
