Title: [900] trunk/activerecord-jdbc: - Wrap up a few more fixes preparing for 0.7 .2 release
Revision
900
Author
nicksieger
Date
2008-02-12 13:46:30 -0500 (Tue, 12 Feb 2008)

Log Message

- Wrap up a few more fixes preparing for 0.7.2 release
- Document all fixes in history

Modified Paths

Diff

Modified: trunk/activerecord-jdbc/History.txt (899 => 900)


--- trunk/activerecord-jdbc/History.txt	2008-02-12 12:05:40 UTC (rev 899)
+++ trunk/activerecord-jdbc/History.txt	2008-02-12 18:46:30 UTC (rev 900)
@@ -1,6 +1,19 @@
 == 0.7.2
 
-- Fix for add_column for derby, hsqldb, and postgresql (JRUBY-1905; Stephen Bannasch)
+- JRUBY-1905: add_column for derby, hsqldb, and postgresql (Stephen Bannasch)
+- Fix db:create for JDBC
+- Support Rails 2 with the old "require 'jdbc_adapter'" approach
+- JRUBY-1966: Instead of searching for just tables, search for views and tables.
+- JRUBY-1583: DB2 numeric quoting (Ryan Shillington)
+- JRUBY-1634: Oracle DATE type mapping (Daniel Wintschel)
+- JRUBY-1543: rename_column issue with more recent MySQL drivers (Oliver Schmelzle)
+- Rubyforge #15074: ConnectionAdapters::JdbcAdapter.indexes is missing name and
+  schema_name parameters in the method signature (Igor Minar)
+- Rubyforge #13558: definition for the indexes method (T Meyarivan)
+- JRUBY-2051: handle schemaname and tablename more correctly for columns
+- JRUBY-2102: Postgres Adapter cannot handle datetime type (Rainer Hahnekamp)
+- JRUBY-2018: Oracle behind ActiveRecord-JDBC fails with "Invalid column index" (K Venkatasubramaniyan)
+- JRUBY-2012: jdbc_mysql structure dump fails for mysql views (Tyler Jennings)
 
 == 0.7.1
 

Modified: trunk/activerecord-jdbc/lib/active_record/connection_adapters/jdbc_adapter.rb (899 => 900)


--- trunk/activerecord-jdbc/lib/active_record/connection_adapters/jdbc_adapter.rb	2008-02-12 12:05:40 UTC (rev 899)
+++ trunk/activerecord-jdbc/lib/active_record/connection_adapters/jdbc_adapter.rb	2008-02-12 18:46:30 UTC (rev 900)
@@ -201,6 +201,10 @@
         types = @types
         procs.each do |p|
           new_types = types.select(&p)
+          new_types = new_types.inject([]) do |typs,t|
+            typs << t unless typs.detect {|el| el['type_name'] == t['type_name']}
+            typs
+          end
           return new_types.first if new_types.length == 1
           types = new_types if new_types.length > 0
         end

Modified: trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_db2.rb (899 => 900)


--- trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_db2.rb	2008-02-12 12:05:40 UTC (rev 899)
+++ trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_db2.rb	2008-02-12 18:46:30 UTC (rev 900)
@@ -75,7 +75,7 @@
       if column && column.type == :primary_key
         return value.to_s
       end
-      if column && column.type == :decimal && value
+      if column && (column.type == :decimal || column.type == :integer) && value
         return value.to_s
       end
       case value

Modified: trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_mysql.rb (899 => 900)


--- trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_mysql.rb	2008-02-12 12:05:40 UTC (rev 899)
+++ trunk/activerecord-jdbc/lib/jdbc_adapter/jdbc_mysql.rb	2008-02-12 18:46:30 UTC (rev 900)
@@ -188,7 +188,8 @@
     end
 
     def rename_column(table_name, column_name, new_column_name) #:nodoc:
-      current_type = select_one("SHOW COLUMNS FROM #{quote_table_name(table_name)} LIKE '#{column_name}'")["Type"]
+      cols = select_one("SHOW COLUMNS FROM #{quote_table_name(table_name)} LIKE '#{column_name}'")
+      current_type = cols["Type"] || cols["COLUMN_TYPE"]
       execute "ALTER TABLE #{quote_table_name(table_name)} CHANGE #{quote_table_name(column_name)} #{quote_column_name(new_column_name)} #{current_type}"
     end
     
_______________________________________________
Jruby-extras-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/jruby-extras-devel

Reply via email to