OK - sorry for the confusion. It appears there were two problems: 1)
I was not subscribed to commits so my commits were requiring approval
and 2) I was accidentally editing/committing to the import branch
instead of the trunk.
I have now merged all of my changes from the import branch into the
trunk and verified all of the changes/JIRA issues that I marked
resolved last night. Please check out the sample app now - it should
be working!
I did notice that we have a few unit test failures, but these seem
unrelated to my changes.
Jeremy
On Mar 2, 2009, at 10:28 AM, Jeremy Haile wrote:
Oh no - all of my changes were made in the import directory. I just
realized this. Alright - I'll see if I can merge them into the
regular trunk. Bleh.
On Mar 2, 2009, at 10:22 AM, Jeremy Haile wrote:
I didn't realize I wasn't subscribed (but I wasn't). I subscribed
this morning. I guess that's what caused my commits to go in the
review queue.
Hopefully it won't take too long for my commits to be approved.
Jeremy
On Mar 2, 2009, at 10:12 AM, Les Hazlewood wrote:
Very odd - hopefully we can get this resolved asap. I started re-
opening
issues because they didn't co-incide with SVN, then I stopped to
check what
is going on.
Also, according to Alan, as a developer you must be subscribed to
the commit
mailing list, otherwise your commits get stuck in the review
queue. You
might want to subscribe asap :)
Please go ahead and close the issues once the commits are
propagated - I was
just making sure that we still tracked those issues until the code
was
actually in the repo.
- Les
On Mon, Mar 2, 2009 at 9:45 AM, Jeremy Haile <[email protected]>
wrote:
Apparently Alan is having to manually approve my commits? I'm
not quite
sure I understand what is going on. From my side they went through
successfully, but aren't yet applied in SVN for some reason.
On Mar 2, 2009, at 8:57 AM, Les Hazlewood wrote:
Was there a problem with the SVN servers? I'm not seeing any of
the
implementation you referenced in your Jira issues in the source
viewable
here: https://svn.apache.org/repos/asf/incubator/jsecurity/trunk
Anyone have any idea what's going on?
On Sun, Mar 1, 2009 at 10:34 PM, Jeremy Haile
<[email protected]> wrote:
I spent time today updating the Spring-Hibernate sample app. My
goals
were
1) to reduce the amount of code clutter and make it very
simple and 2)
to
use the latest Spring/Hibernate best practices, especially
annotation
configuration.
I'd appreciate any feedback on the changes I committed,
including ideas,
criticisms, or requests for demonstrations of other JSecurity
features.
You
should be able to checkout from SVN and run the
"samples.spring-hibernate.deploy" ant task to deploy the app to
a local
Tomcat instance.
The sample app code is located under samples/spring-hibernate.
Jeremy
