My tests with IE haven't thrown any errors that I've seen -- I'm using IE9 to regress back through IE8 and IE7. I did find that the rendering needs a little love in IE8, as it looks like the overlay isn't getting hidden properly, but no errors are logged in the console. (IE9 supports console, even when rendering as older browsers.)
Or am I missing something else? On Tue, Aug 2, 2011 at 10:43 AM, Xavier MONTILLET <[email protected]>wrote: > Well then detect it and do'nt do anything because, if I remember well, your > actual code would send a useless error. > On Aug 2, 2011 10:40 AM, "Skyler Brungardt" <[email protected]> > wrote: > > I decided to forego support for IE6 and older -- IIRC, IE7 implemented > XHR, > > but still uses the old event listener model. > > > > Ah, nice catch on the for loops. Updated. Thanks! > > > > On Tue, Aug 2, 2011 at 10:30 AM, Xavier MONTILLET > > <[email protected]>wrote: > > > >> You don't use the activex version of xhr whereas you fall back to > >> attachevent if addeventlistener isn't here... > >> You can decide to drop ie or not but not half... > >> And in ie xmlhttprequest.prototype.whatever > >> The property you store in a variable at the beginning will throw an > error > >> in old ie versions as xmlhttprequest wonlt be defined. > >> > >> And in you for loops, you don't declare the i (or j or whatever) > variable > >> with the var operator. > >> > >> I'll take a deeper look later if needed becaise right now I'm on my > >> smartphone.. > >> On Aug 2, 2011 6:24 AM, "Skyler Brungardt" <[email protected]> > wrote: > >> > Hey folks. I'd like to submit some code for your feedback and > >> > critique. > >> > > >> > Some (brief) context. At the organization for which I work, we're > >> > striving to meet the WCAG 2.0 AA spec (link: > >> http://www.w3.org/TR/WCAG20/). > >> > However, that usually precludes having many nifty CSS features and > >> > rich media, since the WCAG spec is fairly specific about how content > >> > can be presented -- specifically what kinds of contrast the content > >> > needs to have based upon its color and its background. > >> > > >> > You can see some examples of what's compliant and what isn't with this > >> > tool: http://snook.ca/technical/colour_contrast/colour.html > >> > > >> > Needless to say, our design team balked at having their color palette > >> > restricted to such a limited set of colors. So I wrote this JS > >> > library to let us have our cake and eat it too. > >> > > >> > Essentially, it provides a widget on a site for enabling high-contrast > >> > styling regardless of the default appearance, and for making fonts > >> > easier to read. I'd like to have it be as turn-key as possible, and > >> > there's still some work to be done in that realm I think. > >> > > >> > I have it up on github here: > >> > https://github.com/StrictlySkyler/accessorizejs/blob/master/accessorize.js > >> > > >> > I welcome your feedback! > >> > > >> > Thanks, > >> > > >> > -Skyler > >> > > >> > -- > >> > To view archived discussions from the original JSMentors Mailman list: > >> http://www.mail-archive.com/[email protected]/ > >> > > >> > To search via a non-Google archive, visit here: > >> http://www.mail-archive.com/[email protected]/ > >> > > >> > To unsubscribe from this group, send email to > >> > [email protected] > >> > >> -- > >> To view archived discussions from the original JSMentors Mailman list: > >> http://www.mail-archive.com/[email protected]/ > >> > >> To search via a non-Google archive, visit here: > >> http://www.mail-archive.com/[email protected]/ > >> > >> To unsubscribe from this group, send email to > >> [email protected] > >> > > > > -- > > To view archived discussions from the original JSMentors Mailman list: > http://www.mail-archive.com/[email protected]/ > > > > To search via a non-Google archive, visit here: > http://www.mail-archive.com/[email protected]/ > > > > To unsubscribe from this group, send email to > > [email protected] > > -- > To view archived discussions from the original JSMentors Mailman list: > http://www.mail-archive.com/[email protected]/ > > To search via a non-Google archive, visit here: > http://www.mail-archive.com/[email protected]/ > > To unsubscribe from this group, send email to > [email protected] > -- To view archived discussions from the original JSMentors Mailman list: http://www.mail-archive.com/[email protected]/ To search via a non-Google archive, visit here: http://www.mail-archive.com/[email protected]/ To unsubscribe from this group, send email to [email protected]
