Some other remarks : - undefined isn't protected - I think the fireEvent function should catch execpetions when calling Function.prototype.call. It ensures that a failing listener won't prevent the other listeners to work.
On 30 oct, 12:40, Bence Erős <[email protected]> wrote: > Hello, > > thank you Gildas, I fixed the coding style, JSHint currently doesn't report > any warnings. > Raynos, I replied to your issues on github. > > thanks again for both of you, > Bence > > 2011/10/29 Gildas <[email protected]> > > > > > > > > > > > Hi Bence, > > > First, I'll recommend you to use a code quality tool like jshint. It > > really helps to fix common bugs like undeclared variables (e.g. > > "comparator"). > > > The report is here:http://www.jshint.com/reports/50009 > > > On 29 oct, 18:41, Bence Erős <[email protected]> wrote: > > > Hello JS Mentors, > > > > this is my first mail on this list, so first of all let me introduce > > myself. > > > I'm Bence Eros from Hungary, I'm a freelancer web application developer > > and > > > a finalist university student. > > > > So, a few weeks ago I created a library which wraps all items of a data > > > structure into wrapper functions, and makes it possible to add event > > > listeners to data items, fired on data changes. More about the reasons > > and > > > features can be found on GitHub: > >https://github.com/crystal88/jquery.observable > > > > I would be pleased if someone would review my code. > > > > Later on I will build a UI framework on the top of this, primarily > > targeting > > > massive data binding - but this time I'm interested in your opinion about > > > the jquery.observable library. > > > > thanks & regards, > > > -- > > > *Bence Erős * > > > +36-70-354-3351http://erosbence.blogspot.com > > > -- > > To view archived discussions from the original JSMentors Mailman list: > > http://www.mail-archive.com/[email protected]/ > > > To search via a non-Google archive, visit here: > >http://www.mail-archive.com/[email protected]/ > > > To unsubscribe from this group, send email to > > [email protected] > > -- > *Bence Erős * > +36-70-354-3351http://erosbence.blogspot.com -- To view archived discussions from the original JSMentors Mailman list: http://www.mail-archive.com/[email protected]/ To search via a non-Google archive, visit here: http://www.mail-archive.com/[email protected]/ To unsubscribe from this group, send email to [email protected]
