Author: metskem
Date: Sun Dec 28 10:42:50 2008
New Revision: 729761
URL: http://svn.apache.org/viewvc?rev=729761&view=rev
Log:
JSPWIKI-459 improvement for the PluginIndexPlugin JUnit test
Modified:
incubator/jspwiki/trunk/tests/com/ecyrd/jspwiki/plugin/PluginIndexPluginTest.java
Modified:
incubator/jspwiki/trunk/tests/com/ecyrd/jspwiki/plugin/PluginIndexPluginTest.java
URL:
http://svn.apache.org/viewvc/incubator/jspwiki/trunk/tests/com/ecyrd/jspwiki/plugin/PluginIndexPluginTest.java?rev=729761&r1=729760&r2=729761&view=diff
==============================================================================
---
incubator/jspwiki/trunk/tests/com/ecyrd/jspwiki/plugin/PluginIndexPluginTest.java
(original)
+++
incubator/jspwiki/trunk/tests/com/ecyrd/jspwiki/plugin/PluginIndexPluginTest.java
Sun Dec 28 10:42:50 2008
@@ -1,5 +1,6 @@
package com.ecyrd.jspwiki.plugin;
+import java.util.Collection;
import java.util.Properties;
import org.apache.jspwiki.api.PluginException;
@@ -10,6 +11,7 @@
import com.ecyrd.jspwiki.TestEngine;
import com.ecyrd.jspwiki.WikiContext;
+import com.ecyrd.jspwiki.plugin.PluginManager.WikiPluginInfo;
public class PluginIndexPluginTest extends TestCase
{
@@ -21,6 +23,11 @@
PluginManager manager;
+ Collection<WikiPluginInfo> m_requiredPlugins;
+
+ public static final String[] REQUIRED_COLUMNS = { "Name", "Class Name",
"alias's", "author", "minVersion", "maxVersion",
+ "adminBean Class" };
+
public PluginIndexPluginTest( String s )
{
super( s );
@@ -30,14 +37,13 @@
{
props.load( TestEngine.findTestProperties() );
- // prevent "create" links :
- props.setProperty( "jspwiki.translatorReader.camelCaseLinks", "false"
);
-
engine = new TestEngine( props );
manager = new PluginManager( engine, props );
context = engine.getWikiContextFactory().newViewContext(
engine.createPage( "TestPage" ) );
+
+ m_requiredPlugins = context.getEngine().getPluginManager().modules();
}
public void tearDown()
@@ -51,17 +57,21 @@
}
/**
- * Test for : PluginIndexPlugin details=false Shows only the plugin names
+ * Test for the presence of all core plugins
*
* @throws PluginException
*/
- public void testDetailsFalse() throws PluginException
+ public void testCorePluginsPresent() throws PluginException
{
- String expectedResult = "<p />\n<table class=\"wikitable\"
border=\"1\"><tr
class=\"odd\"><th>name</th></tr>\n<tr><td>BugReportHandler</td></tr>\n<tr
class=\"odd\"><td>Counter</td></tr>\n<tr><td>CurrentTimePlugin</td></tr>\n<tr
class=\"odd\"><td>Denounce</td></tr>\n<tr><td>FormClose</td></tr>\n<tr
class=\"odd\"><td>FormInput</td></tr>\n<tr><td>FormOpen</td></tr>\n<tr
class=\"odd\"><td>FormOutput</td></tr>\n<tr><td>FormSelect</td></tr>\n<tr
class=\"odd\"><td>FormSet</td></tr>\n<tr><td>FormTextarea</td></tr>\n<tr
class=\"odd\"><td>Groups</td></tr>\n<tr><td>IfPlugin</td></tr>\n<tr
class=\"odd\"><td>Image</td></tr>\n<tr><td>IndexPlugin</td></tr>\n<tr
class=\"odd\"><td>InsertPage</td></tr>\n<tr><td>JavaScriptPlugin</td></tr>\n<tr
class=\"odd\"><td>ListLocksPlugin</td></tr>\n<tr><td>Note</td></tr>\n<tr
class=\"odd\"><td>PluginIndexPlugin</td></tr>\n<tr><td>RPCSamplePlugin</td></tr>\n<tr
class=\"odd\"><td>RecentChangesPlugin</td></tr>\n<tr><td>ReferredPagesPlugin</td></tr>\
n<tr
class=\"odd\"><td>ReferringPagesPlugin</td></tr>\n<tr><td>SamplePlugin</td></tr>\n<tr
class=\"odd\"><td>Search</td></tr>\n<tr><td>SessionsPlugin</td></tr>\n<tr
class=\"odd\"><td>TableOfContents</td></tr>\n<tr><td>UndefinedPagesPlugin</td></tr>\n<tr
class=\"odd\"><td>UnusedPagesPlugin</td></tr>\n<tr><td>WeblogArchivePlugin</td></tr>\n<tr
class=\"odd\"><td>WeblogEntryPlugin</td></tr>\n<tr><td>WeblogPlugin</td></tr></table>";
String result = manager.execute( context, "{PluginIndexPlugin
details=false}" );
- // now this is a very straightforward test, if a new plugin is added,
a plugin is removed, this test will have to be modified
- assertEquals( expectedResult, result );
+ // test for the presence of each core plugin (this list can be expanded
+ // as new plugins are added)
+ for( WikiPluginInfo pluginInfo : m_requiredPlugins )
+ {
+ String name = pluginInfo.getName();
+ assertTrue( "plugin '" + name + "' missing", result.contains( name
) );
+ }
}
/**
@@ -70,12 +80,30 @@
*
* @throws PluginException
*/
- public void testDetailsTrue() throws PluginException
+ public void testDetails() throws PluginException
+ {
+ String result = manager.execute( context, "{PluginIndexPlugin
details=true}" );
+
+ // check for the presence of all required columns:
+ for( int i = 0; i < REQUIRED_COLUMNS.length; i++ )
+ {
+ assertTrue( "plugin '" + REQUIRED_COLUMNS[i] + "' missing",
result.contains( REQUIRED_COLUMNS[i] ) );
+ }
+ }
+
+ /**
+ * Test for the number of rows returned (should be equal to the number of
+ * plugins found)
+ *
+ * @throws PluginException
+ */
+ public void testNumberOfRows() throws PluginException
{
- String expectedResult = "<p />\n<table class=\"wikitable\"
border=\"1\"><tr class=\"odd\"><th>Name</th><th>Class
Name</th><th>alias's</th><th>author</th><th>minVersion</th><th>maxVersion</th><th>adminBean
Class</th></tr>\n<tr><td>BugReportHandler</td><td>com.ecyrd.jspwiki.plugin.BugReportHandler</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>Counter</td><td>com.ecyrd.jspwiki.plugin.Counter</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>CurrentTimePlugin</td><td>com.ecyrd.jspwiki.plugin.CurrentTimePlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>Denounce</td><td>com.ecyrd.jspwiki.plugin.Denounce</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>FormClose</td><td>com.ecyrd.jspwiki.forms.FormClose</td><td> </td><td> </td><td> </td><td>
</td><td> </td></tr>\n<tr
class=\"odd\"><td>FormInput</td><td>com.ecyrd.jspwiki.forms.FormInput</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>FormOpen</td><td>com.ecyrd.jspwiki.forms.FormOpen</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>FormOutput</td><td>com.ecyrd.jspwiki.forms.FormOutput</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>FormSelect</td><td>com.ecyrd.jspwiki.forms.FormSelect</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>FormSet</td><td>com.ecyrd.jspwiki.forms.FormSet</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>FormTextarea</td><td>com.ecyrd.jspwiki.forms.FormTextarea</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>Groups</td><td>com
.ecyrd.jspwiki.plugin.Groups</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>IfPlugin</td><td>com.ecyrd.jspwiki.plugin.IfPlugin</td><td>
If</td><td>AnonymousCoward</td><td>0.0</td><td>1000000.0</td><td /></tr>\n<tr
class=\"odd\"><td>Image</td><td>com.ecyrd.jspwiki.plugin.Image</td><td>
</td><td>JSPWiki development group</td><td>0.0</td><td>1000000.0</td><td
/></tr>\n<tr><td>IndexPlugin</td><td>com.ecyrd.jspwiki.plugin.IndexPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>InsertPage</td><td>com.ecyrd.jspwiki.plugin.InsertPage</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>JavaScriptPlugin</td><td>com.ecyrd.jspwiki.plugin.JavaScriptPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>ListLocksPlugin</td><td>com.ecyrd.jspwiki.plugin.ListLocksPlugin<
/td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>Note</td><td>com.ecyrd.jspwiki.plugin.Note</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>PluginIndexPlugin</td><td>com.ecyrd.jspwiki.plugin.PluginIndexPlugin</td><td>
</td><td>Harry Metske</td><td>3.0</td><td>1000000</td><td
/></tr>\n<tr><td>RPCSamplePlugin</td><td>com.ecyrd.jspwiki.plugin.RPCSamplePlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>RecentChangesPlugin</td><td>com.ecyrd.jspwiki.plugin.RecentChangesPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>ReferredPagesPlugin</td><td>com.ecyrd.jspwiki.plugin.ReferredPagesPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>ReferringPagesPlugin</td><td>com.ecyrd.jspwiki.plugin.ReferringP
agesPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>SamplePlugin</td><td>com.ecyrd.jspwiki.plugin.SamplePlugin</td><td>
samplealias2 samplealias</td><td>Urgle
Burgle</td><td>0.0</td><td>1000000.0</td><td /></tr>\n<tr
class=\"odd\"><td>Search</td><td>com.ecyrd.jspwiki.plugin.Search</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>SessionsPlugin</td><td>com.ecyrd.jspwiki.plugin.SessionsPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>TableOfContents</td><td>com.ecyrd.jspwiki.plugin.TableOfContents</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>UndefinedPagesPlugin</td><td>com.ecyrd.jspwiki.plugin.UndefinedPagesPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>UnusedPagesPlugin</td><td>com.ecyrd.jspwi
ki.plugin.UnusedPagesPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>WeblogArchivePlugin</td><td>com.ecyrd.jspwiki.plugin.WeblogArchivePlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr
class=\"odd\"><td>WeblogEntryPlugin</td><td>com.ecyrd.jspwiki.plugin.WeblogEntryPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr>\n<tr><td>WeblogPlugin</td><td>com.ecyrd.jspwiki.plugin.WeblogPlugin</td><td> </td><td> </td><td> </td><td> </td><td> </td></tr></table>";
String result = manager.execute( context, "{PluginIndexPlugin
details=true}" );
-
- // now this is a very straightforward test, if a new plugin is added,
a plugin is removed, this test will have to be modified
- assertEquals( expectedResult, result );
+
+ String row = "<tr";
+ String[] pieces = result.split( row );
+ int numRows = pieces.length - 2;
+ assertEquals( "unexpected number of rows", m_requiredPlugins.size(),
numRows );
}
}
