Hi Murray,
The removal of the <br /> has been in the code for some time now.
(only the i18n didn't yet follow)
If I remember well, i took it out after adding the login-status-icon
to the template.
(as suggested by you)
So now we have following things in the 'userbox':
<div class="userbox">
<span class="username anonymous">
G’day (anonymous guest)
</span>
<a ...>Log in</a>
<a ...>My Prefs</a>
</div>
This gives already quite a lot of freedom for skins.
Following your suggested patch, you'd like to have the status message
in a separate block as well ?
dirk
On 11/4/07, Murray Altheim <[EMAIL PROTECTED]> wrote:
> I thought I'd sent in a patch on this a couple of times now. I'd
> prefer rather than adding or removing the <br /> to split the
> message into two parts, permitting templates to handle the line
> break, as well as changing the formatting of the two strings as
> desired.
>
> Any reason not to do this? In my patches I'd modified the
> messages for all of the included localizations.
>
> Murray (been out of touch for a few days, up in the mountains)
>
>
> Dirk Frederickx (JIRA) wrote:
> > [
> > https://issues.apache.org/jira/browse/JSPWIKI-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Dirk Frederickx resolved JSPWIKI-17.
> > ------------------------------------
> >
> > Resolution: Fixed
> >
> > This problem had to do with the i18n resources for greeting messages.
> > The <br /> need to be removed.
> > Fixed in v2.5.150 (finish, german, spanish localisations)
> >
> >> Login line split into two lines
> >> -------------------------------
> >>
> >> Key: JSPWIKI-17
> >> URL: https://issues.apache.org/jira/browse/JSPWIKI-17
> >> Project: JSPWiki
> >> Issue Type: Bug
> >> Components: Default template
> >> Affects Versions: 2.5.139-beta
> >> Environment: JSPWiki 2.5.149-cvs; Mac OSX Tiger, Firefox 2.0.0.9,
> >> plain vanilla template.
> >> Reporter: Janne Jalkanen
> >> Assignee: Dirk Frederickx
> >> Priority: Minor
> >> Attachments: screenshot-1.jpg
> >>
> >>
> >> Please see attached image.
> >
>
>
> --
>
> ...........................................................................
> Murray Altheim <murray07 at altheim.com> === = =
> http://www.altheim.com/murray/ = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
>
