[
https://issues.apache.org/jira/browse/JSPWIKI-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569616#action_12569616
]
Janne Jalkanen commented on JSPWIKI-187:
----------------------------------------
Please, single patch against a single issue only. Otherwise things get
unmanageable. Also, JSPWIKI-166 and JSPWIKI-102 are already fixed, so I don't
understand the point of this issue.
Propose for WONTFIX, and request to file each issue separately.
> MailUtil issues
> ---------------
>
> Key: JSPWIKI-187
> URL: https://issues.apache.org/jira/browse/JSPWIKI-187
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.1
> Reporter: Florian Holeczek
> Priority: Minor
> Attachments: JSPWIKI-187_patch.zip
>
>
> As I've been announcing on the list, here comes a patch regarding issues 102,
> 166 and 169:
> {quote}
> Hi Janne,
> could you please have a look at JSPWIKI-166 and 169 and then wait a bit
> before releasing 2.6.1?
> I'd like to have a final look at it and add an improvement I mentioned in
> JSPWIKI-102 (improving exception handling and logging regarding usage of JNDI
> or custom mail).
> Would be fine if these MailUtil issues could be fixed completely with 2.6.1
> final.
> Regards,
> Florian
> {quote}
> I've done a review on MailUtil and done several tests using JNDI and custom
> mail sessions.
> * This patch improves the information flow to the standard user (log level
> info) as well as the administrator (log level debug).
> * Additionally, I've found and fixed a bug: mail.smtp.timeout and
> mail.smtp.connectiontimeout weren't read out of jspwiki.properties.
> * The patch for jspwiki.properties.tmpl should make mail configuration
> clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
