Well, this issue is not the icon ...
Actually the tag should probably be extended with a page parameter, cause the current tag only issues a rss url for the whole wiki, and not a feed of a particular page. dirk On Wed, May 14, 2008 at 9:29 PM, Janne Jalkanen <[EMAIL PROTECTED]> wrote: > > On May 14, 2008, at 22:15 , Dirk Frederickx wrote: > >> Janne, >> >> >> This allows skins to change the image. >> >> This has been a generic approach throughout the new template. (logo's, >> other images, only the attachment icons still need to be handled) >> Ensure presentation stuff is moved to css, so it can be changed >> according the skins. >> >> In the below code snippit, the should actually be changed by a >> line-of-text, eg "RSS-feed", so things are still accessible when icons >> are not loaded. > > But it causes a massive cases of duplicate code all around! We've got the > perfectly good RSSImageLink tag, so we should use it instead. Note that now > we are using both, so a skin cannot really change the icon at all. > > Also, I am not sure whether that increases accessibility (I know, it's > already pretty bad), but having a as link text is probably not what > we really want. > > I think it should be much better to move all this code into RSSImageLinkTag. > > /Janne >
