I think it would be better if there was another id for the tab (e.g.
"tab-pagecontent"), and we kept the "pagecontent" id as a separate
div. I think we're relying in other places on the pagecontent id to
be found as well, so this might very well pop up in other contexts.
Tabs should be a part of the presentation, not the logical content of
the page. These should be separated in different name-spaces.
/Janne
On 15 May 2008, at 09:32, Dirk Frederickx wrote:
Janne,
There is even a more simple solution. The content of the page is
already enclosed in a <div id="page">, so the collapse-javascript
should use that id iso the pagecontent id. I'll commit that next
time.
Each tab needs to have an id in order for the tabs to function
properly. So it'd better stays as part of the tab.
dirk
On 5/15/08, Janne Jalkanen (JIRA) <[EMAIL PROTECTED]> wrote:
[ https://issues.apache.org/jira/browse/JSPWIKI-269?
page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel&focusedCommentId=12596960#action_12596960 ]
Janne Jalkanen commented on JSPWIKI-269:
----------------------------------------
What about simply using
{code}
<wiki:TabbedSection>
<wiki:Tab>
<div id="pagecontent">
...
</div>
</wiki:Tab>
</wiki:TabbedSection>
{code}
Better way to handle javascript support for collapsible lists
-------------------------------------------------------------
Key: JSPWIKI-269
URL: https://issues.apache.org/jira/browse/
JSPWIKI-269
Project: JSPWiki
Issue Type: Improvement
Components: Default template
Affects Versions: 2.6.2
Environment: Fedora FC6/7
Firefox 1.5.0.12
Reporter: Terry Steichen
Assignee: Dirk Frederickx
Priority: Minor
At present, if <wiki:TabbedSection> and <wiki:Tab> tags are
removed from PageContent.jsp (and maybe others), collapsible
lists cease working. The workaround is to add a <div
id="pagecontent"> tag. What's needed is a more flexible way to
implement collaspsible lists without making it so dependent on a
particular page's structure.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
